I apologize in advance for the lengthy post...
I do agree that hub motors are better for some uses, mid-drives for some others but I think that motor efficiency vs speed needs a bit more clarification. I ran the Grin Motor Simulator for their
GMAC hub motor. It's efficiency peaks at 84.5% near 26.7mph with a power draw of 652W. BTW - You'll need to tap on the charts to get the speeds referenced in this writeup.
Next I took a look at the mid-drive Bafang BBS02 with same battery, controller, and wheel size. Being a MDM, gear ratio is now a consideration as well. I used my ebike's gearing as an example, 46t chain ring and a 11x42 cassette. To consider higher speed efficiency I went with the
46x11 gearing. This setup reaches 81.6% efficiency at ~39mph with a power draw of 449W. An efficiency edge to the hub motor of ~3 percentage points.
But what about absolute power draw? The hub motor is operating at 84.5% of its design efficiency, but needs 652W of power. Even though the MDM is operating at a lower 81.6% of its design efficiency it needs just 449W. There are lots of other motors that could be modeled but the point is that operating efficiency is not necessairly the same as minimum power usage. I personally have noticed this between my original DIY hub bike vs my replacement MDM. I use less battery power for the same rides on the MDM bike than I did on the hub drive bike.
Now, what about other speeds? I often ride in the 15mph range around town. Using the same Simulator setups but adjusting speed by tapping on the chart the hub motor still has an efficiency advantage but the power draw is now ~876W vs ~673W, a substantial 200W savings with the MDM.
YRMV but it is important to consider motor power draw. Just sayin'